Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external_velocity_limit_selector): revert "refactor(external_velocity_limit_selector): rework parameter (#5238)" (#6132) #1135

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Feb 8, 2024

Description

backport from autowarefoundation#6132

Related Links

https://tier4.atlassian.net/browse/RT0-30609

Tests performed

I confirmed in https://tier4.atlassian.net/browse/RT0-30609?focusedCommentId=155732

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@0x126
Copy link

0x126 commented Feb 9, 2024

@0x126 0x126 merged commit 07e919b into beta/v0.19.1 Feb 13, 2024
17 of 18 checks passed
@0x126 0x126 deleted the backport/6132 branch February 13, 2024 04:42
@h-ohta
Copy link
Author

h-ohta commented Apr 18, 2024

@Mergifyio backport beta/v0.19.2

Copy link

mergify bot commented Apr 18, 2024

backport beta/v0.19.2

❌ No backport have been created

  • Backport to branch beta/v0.19.2 failed

GitHub error: Branch not found

@h-ohta
Copy link
Author

h-ohta commented Apr 18, 2024

@Mergifyio backport beta/v0.19.2

Copy link

mergify bot commented Apr 18, 2024

backport beta/v0.19.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 18, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
(cherry picked from commit 07e919b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants